-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preload): experimental LD_PRELOAD env hook #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
force-pushed
the
experimental/ld-preload
branch
4 times, most recently
from
June 24, 2024 10:42
3765925
to
56b0f7b
Compare
Quality Gate passedIssues Measures |
basti1302
force-pushed
the
main
branch
3 times, most recently
from
June 26, 2024 15:05
ffa895f
to
4f73408
Compare
basti1302
force-pushed
the
experimental/ld-preload
branch
from
September 23, 2024 04:23
56b0f7b
to
6d3a6ec
Compare
(instead of once per getenv call)
Also, convert all shell scripts to POSIX-compliant sh scripts and apply most shellcheck suggestions.
The previous build & test setup was invalid: So far we have built _different_ libdash0envhook.so binaries for the LD_PRELOAD hook per libc flavor. With this, the binary works in the target system. But actually this approach is not not possible in the real world. We can set one binary as LD_PRELOAD when instrumenting a container and we do not know which libc flavor it is ahead of time. Thus we ultimately need to build a libdash0envhook.so binary that works independently of which libc flavor the target system uses. This commit only fixes the test setup. The binary does not yet support both libc flavors. This will be handled in a follow up commit. [skip ci]
basti1302
force-pushed
the
experimental/ld-preload
branch
from
October 18, 2024 11:10
6d3a6ec
to
38aa8fc
Compare
Quality Gate passedIssues Measures |
Closing in favor of #155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.